crane fix #1959
Merged
crane fix #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jpraynaud
approved these changes
Sep 26, 2024
dlachaume
approved these changes
Sep 26, 2024
sfauvel
approved these changes
Sep 26, 2024
|
@locallycompact Many thanks for your PR ! Can you rebase it over main ? I would like to check that #1960 wasn't hiding other errors. Previously I tried a fix similar to yours and there was malloc errors that I could not explain. |
|
@locallycompact can you also sign the commits, as we can not merge the branch otherwise? |
locallycompact
force-pushed
the
lc/crane-fix
branch
2 times, most recently
from
90b26f8 to
284ffd9
Compare
By running 'nix flake update' command.
|
Rebased this now and also dropped the now invalid override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the
nixpackage which was broken after running anix flake updatecommand.Pre-submit checklist
Issue(s)
Closes #1928